Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling flaky test reporting for UI tests into testomatio. #41

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Enabling flaky test reporting for UI tests into testomatio. #41

merged 1 commit into from
Feb 2, 2024

Conversation

achakko
Copy link
Contributor

@achakko achakko commented Feb 2, 2024

Description:

PG-3174 This PR enables reporting for UI tests into testomat for each CI run

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

snake14
snake14 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The one test case is tracking in Testomat 👍

@snake14 snake14 merged commit 30b3759 into 5.x-dev Feb 2, 2024
1 check passed
@snake14 snake14 deleted the pg3174-testomat branch February 2, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achakko @snake14